findAllReferences: Consistently use getTextSpan#22847
Merged
2 commits merged intoMar 28, 2018
Merged
Conversation
mhegazy
reviewed
Mar 28, 2018
|
|
||
| function getTextSpan(node: Node): TextSpan { | ||
| let start = node.getStart(); | ||
| function getTextSpan(node: Node, sourceFile = node.getSourceFile()): TextSpan { |
Contributor
There was a problem hiding this comment.
no need for the initializer, you want to pass the sourceFile if you have it, otherwise, getStart will walk up and find it, if it needs it.
mhegazy
approved these changes
Mar 28, 2018
Contributor
mhegazy
left a comment
There was a problem hiding this comment.
👍 With removing the initializer
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22690