Js constructor function fixes#22721
Merged
Merged
Conversation
Symbol-based now instead of syntactic
RyanCavanaugh
approved these changes
Mar 20, 2018
|
|
||
| if (isPropertyAccessExpression(expression.left) && expression.left.expression.kind === SyntaxKind.ThisKeyword) { | ||
| if (getThisContainer(expression, /*includeArrowFunctions*/ false).kind === SyntaxKind.Constructor) { | ||
| const thisContainer = getThisContainer(expression, /*includeArrowFunctions*/ false); |
Member
There was a problem hiding this comment.
An explanatory comment would be nice to have here
RyanCavanaugh
approved these changes
Mar 20, 2018
weswigham
approved these changes
Mar 20, 2018
ghost
reviewed
Mar 20, 2018
| if (isPropertyAccessExpression(expression.left) && expression.left.expression.kind === SyntaxKind.ThisKeyword) { | ||
| if (getThisContainer(expression, /*includeArrowFunctions*/ false).kind === SyntaxKind.Constructor) { | ||
| const thisContainer = getThisContainer(expression, /*includeArrowFunctions*/ false); | ||
| const isPrototypeProperty = isBinaryExpression(thisContainer.parent) && |
There was a problem hiding this comment.
Only used if thisContainer.kind === SyntaxKind.FunctionExpression, might want to avoid computing this otherwise.
This was referenced Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS constructors had a couple of bugs with strictNullChecks (which people actually do use with checkJs, see the recent post by @OliverJAsh).
undefinedto the type of all properties:Incorrectly had
x: number | undefinednotx: number.This incorrectly had
a: { x: number } | undefinedwhen it should have beena: { x: number }Fixes #22414
Fixes #22641
Note that the second fix checks two things to distinguish a constructor function from a normal one:
return new A()somewhere insidefunction A. It doesn't check whether this statement is inside a conditional.