Don't add external module completions in a pure commonjs file#22583
Merged
1 commit merged intoMar 15, 2018
Merged
Conversation
Member
|
I know @RyanCavanaugh has thoughts on this. |
amcasey
approved these changes
Mar 14, 2018
amcasey
left a comment
Member
There was a problem hiding this comment.
LGTM but please confirm with Ryan.
Member
|
I'm fine with a bugfix for not including them since the current behavior is wrong, but we could also consider synthesizing const { readFile } = require('fs');as a stretch goal at a later date. |
Author
|
Filed #22602 |
ghost
pushed a commit
that referenced
this pull request
Mar 26, 2018
ghost
pushed a commit
that referenced
this pull request
Mar 26, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22574