Skip to content

Brackets and postfix= in @param add undefined #22514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nathan Shively-Sanders (sandersn) merged 2 commits into from
Mar 13, 2018
Merged

Brackets and postfix= in @param add undefined #22514

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c84ccf
Brackets and postfix= in `@param` add undefined
sandersn Mar 13, 2018
7cb96ee
Address PR comments
sandersn Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address PR comments
  • Loading branch information
@sandersn
sandersn committed Mar 13, 2018
commit 7cb96ee6dd9ec9d041418d29fbf9f78a424c61e9
8 changes: 3 additions & 5 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4167,11 +4167,9 @@ namespace ts {

let isOptional = false;
if (includeOptionality) {
if (isInJavaScriptFile(declaration) && isParameterDeclaration(declaration)) {
const parameterTags = getJSDocParameterTags(declaration as ParameterDeclaration);
if (parameterTags && parameterTags.length > 0 && find(parameterTags, tag => tag.isBracketed)) {
isOptional = true;
}
if (isInJavaScriptFile(declaration) && isParameter(declaration)) {
const parameterTags = getJSDocParameterTags(declaration);

@ghost Deleted user (ghost) Mar 13, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cast not valid, isParameterDeclaration returns true for non-parameters (maybe the name could use an improvement).

@sandersn Nathan Shively-Sanders (sandersn) Mar 13, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, isParameter isn't obvious since it's one of the few types that don't match the name of their syntax kind.

isOptional = !!(parameterTags && parameterTags.length > 0 && find(parameterTags, tag => tag.isBracketed));

@ghost Deleted user (ghost) Mar 13, 2018 •
edited by ghost
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler to write isOptional = ... than if (...) isOptional = true;

@sandersn Nathan Shively-Sanders (sandersn) Mar 13, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so. Doesn't match the next branch, so it makes the code a little less obvious to read.

}
if (!isBindingElement(declaration) && !isVariableDeclaration(declaration) && !!declaration.questionToken) {
isOptional = true;
Expand Down