Change es2015 transform to retain comments on for of loop bodies#22396
Merged
Conversation
rbuckton
approved these changes
Mar 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a change in our RWC suite.
When comment emit got greatly improved recently, it shifted the responsibility of what node needed to have correct positions to actually retain comments in the tested scenario. With this change, the es2015 transform will now actually set the original node and positions on the block of a for of loop, if present, when it is transformed, so it can retain comments attached to its opening and closing tokens. Incidentally, the comment:
seemed to indicate a TODO with respect to the sourcemaps, which I gather I have just done, by using
updateBlockinstead of always making a synthetic one.