Allow indexing generics with unique symbols#22339
Merged
Merged
Conversation
| // If the current iteration type constituent is a string literal type, create a property. | ||
| // Otherwise, for type string create a string index signature. | ||
| if (t.flags & TypeFlags.StringLiteral) { | ||
| const propName = escapeLeadingUnderscores((<StringLiteralType>t).value); |
Member
There was a problem hiding this comment.
Since this is a StringLiteral, does this need to be changed? Is it just for consistency?
Member
Author
There was a problem hiding this comment.
Mostly, yeah. The function below is used up above in the same body and is the correct one to use for future support of symbols as mapped type keys.
ahejlsberg
requested changes
Mar 5, 2018
| getLiteralType(symbolName(prop)); | ||
| const links = getSymbolLinks(prop); | ||
| if (!links.nameType) { | ||
| if (links.target && links.target.escapedName === prop.escapedName) { |
Member
There was a problem hiding this comment.
Shouldn't have to check names here.
Member
Author
There was a problem hiding this comment.
Moved to debug assertion.
ahejlsberg
approved these changes
Mar 5, 2018
Contributor
|
I think you mean: trie[letter][END_WORD] = END_VALUE;instead of trie[END_WORD] = END_VALUE; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22320