Debug assert on parent rebind, mitigate circularity in symbol access checking#22282
Merged
weswigham merged 2 commits intoMar 2, 2018
Merged
Conversation
mhegazy
approved these changes
Mar 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #20808
I can't think of or find an actual test case to repro the telemetry issue, but by adding an assertion that parent pointers are never rebound to a different parent, the source of a crash if caused by bad binder behavior should be moved to somewhere where it should be possible to see what structure could produce such behavior. Additionally, by making a stackmap that is shared between recursive calls to
getAccessibleSymbolChain, it should avoid ever running out of stack on a circular parent structure, as well (if for some reason something other than the binder is intentionally introducing one), since the visibility logic works fine in the presence of such a structure.