Reduce duplicate code for TextChange overlaps#22278
Merged
Conversation
aastikta28
suggested changes
Mar 2, 2018
| if (intersectStart <= intersectEnd) { | ||
| return createTextSpanFromBounds(intersectStart, intersectEnd); | ||
| } | ||
| return undefined; |
There was a problem hiding this comment.
You haven't done any logic changes here. From what I can see, renamed the variables and re written the logic using ternary operator. Is there anything am missing here?
Author
There was a problem hiding this comment.
Yeah, this PR isn't meant to change the return values of anything.
| } | ||
| return undefined; | ||
| const overlap = textSpanIntersection(span1, span2); | ||
| return overlap && overlap.length === 0 ? undefined : overlap; |
There was a problem hiding this comment.
here maybe consider doing return textSpanIntersection(span1, span2) as it returns undefined if no value.
Author
There was a problem hiding this comment.
textSpanIntersection doesn't return undefined if there's a 0-size intersection (the ranges are right up against each other), but this function does. So they're not exactly the same.
mhegazy
approved these changes
Mar 2, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions all compute the same thing in slightly different ways.