factory: replace Array parameters with ReadonlyArray#22261
Merged
Conversation
Contributor
Author
|
CI failure on Travis testing with Node 6 looks unrelated to this change |
aastikta28
approved these changes
Mar 1, 2018
mhegazy
approved these changes
Apr 3, 2018
Contributor
|
@rbuckton any comments? |
rbuckton
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that some Node factory functions take arrays as arguments. They actually don't need to be mutable so I changed them to ReadonlyArray for better ergonomics when using existing NodeArrays.