mergeMapLikes: Improve type#22237
Merged
4 commits merged intoMar 1, 2018
Merged
Conversation
| } | ||
|
|
||
| export function mergeMapLikes(target: MapLike<any>, source: MapLike<any>): void { | ||
| export function mergeMapLikes<T>(target: T, source: T): void { |
Member
There was a problem hiding this comment.
Why not MapLike<T> and MapLike<T>? If not, should source have the type Partial<T>?
Author
There was a problem hiding this comment.
If we write MapLike<T> that disallows to call it on a non-MapLike like FormatCodeSettings. We're actually never calling this function on MapLikes... but you're right that source could be Partial<T>.
added 2 commits
February 28, 2018 14:30
mhegazy
approved these changes
Feb 28, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this would allow to merge completely unrelated types.