Skip to content

Add semicolons to import helpers#22212

Merged
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:add-semicolons-to-helpers
Feb 28, 2018
Merged

Add semicolons to import helpers#22212
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:add-semicolons-to-helpers

Conversation

@weswigham
Copy link
Copy Markdown
Member

Fixes #22107

I've also opened microsoft/tslib#48 on tslib to track linting the helpers there.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Feb 27, 2018

@DanielRosenwasser can we push a new version of the library

@DanielRosenwasser
Copy link
Copy Markdown
Member

@mhegazy I don't think tslib needs a new version since all the declarations are initialized in a helper function's body https://github.com/Microsoft/tslib/blob/3d0f4d4823605e6e82cf250b509d9a685c42ad41/tslib.js

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Feb 27, 2018

aah.. sorry.. u are right.. need to drink more coffee.

@weswigham weswigham merged commit dafa732 into microsoft:master Feb 28, 2018
@weswigham weswigham deleted the add-semicolons-to-helpers branch February 28, 2018 00:11
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants