Skip to content

Minor cleanup in getRenameInfoForNode#22130

Merged
1 commit merged into
masterfrom
getRenameInfoForNode
Feb 22, 2018
Merged

Minor cleanup in getRenameInfoForNode#22130
1 commit merged into
masterfrom
getRenameInfoForNode

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 22, 2018

  • kind is always defined (uses ScriptElementKind.unknown for error)
  • No need to strip quotes from StringLiteral#text, which already does not contain the quotes.

@ghost ghost requested a review from armanio123 February 22, 2018 22:59
@ghost ghost merged commit 73947b6 into master Feb 22, 2018
@ghost ghost deleted the getRenameInfoForNode branch February 22, 2018 23:52
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant