Fix bug: don't call addIndirectUser if we're not tracking indirect users#22121
Merged
1 commit merged intoFeb 22, 2018
Merged
Conversation
ghost
commented
Feb 22, 2018
| ////} | ||
|
|
||
| // @Filename: /b.ts | ||
| ////import * as a from "a"; |
Member
There was a problem hiding this comment.
Heh. I had this open in multiple editors with both versions in each to directly compare where their execution differed. I did not notice that the wrong version had been saved 🐈 Thanks.
weswigham
approved these changes
Feb 22, 2018
Member
weswigham
left a comment
There was a problem hiding this comment.
I don't think there's a way to disambiguate just by looking at the import syntactically.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22104
@weswigham Is there a way we can avoid calling
addIndirectUseron every default import -- only if it's acting like a namespace import?