Skip to content

fix --pretty output when context is multi-line#22098

Merged
DanielRosenwasser merged 1 commit into
microsoft:masterfrom
alexeagle:pretty
Feb 23, 2018
Merged

fix --pretty output when context is multi-line#22098
DanielRosenwasser merged 1 commit into
microsoft:masterfrom
alexeagle:pretty

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Feb 21, 2018

Fixes #22097

@DanielRosenwasser
Copy link
Copy Markdown
Member

Mmm, great that the tests all pass, but can't help but feel like we should actually have some test baselines for this. Can you add the test case you wrote up to test/cases/compiler and baseline that?

@weswigham
Copy link
Copy Markdown
Member

// @pretty: true
inside the test with an error should be enough to make the pretty output to be captured in the baseline 😉

@msftclas
Copy link
Copy Markdown

msftclas commented Feb 23, 2018

CLA assistant check
All CLA requirements met.

@alexeagle
Copy link
Copy Markdown
Contributor Author

Okay, added the test and baselines - do I check in all the baselines including the symbols for example?

@weswigham
Copy link
Copy Markdown
Member

Yeah. Type and symbol baselines are currently mandatory for all compiler tests, even if they're not critical to testing the issue.

@DanielRosenwasser DanielRosenwasser merged commit 4d284d6 into microsoft:master Feb 23, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--pretty output is missing newlines in multi-line context

4 participants