Skip to content

Enable navbar for export defaults#2204

Closed
mhegazy wants to merge 1 commit into
exportDefaultfrom
exportDefaultLS
Closed

Enable navbar for export defaults#2204
mhegazy wants to merge 1 commit into
exportDefaultfrom
exportDefaultLS

Conversation

@mhegazy
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy commented Mar 5, 2015

Fixes #2202

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray space at the end, add a space after "default"; also I think this was a little cleaner when you just used an intermediate variable (nodeName).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the syntax is of type export default function foo() {} shouldn't you be showing foo instead of default?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Mar 15, 2015

moved to #2368

@mhegazy mhegazy closed this Mar 15, 2015
@mhegazy mhegazy deleted the exportDefaultLS branch March 15, 2015 20:24
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants