Apply 'no-unnecessary-initializer' lint rule#22014
Merged
3 commits merged intoMar 6, 2018
Merged
Conversation
added 3 commits
February 17, 2018 13:39
Forbids `let`/`const` statements to be initialized to `undefined`, since that's the initial value by default anyway. The auto-fixer also happened to remove two unnecessary `as number` casts in `src/harness/parallel/worker.ts`. For historical data: to run with `--fix`, I modified the line in `Jakefile.js` that declared the `cmd` for running TSLint.
# Conflicts: # src/compiler/parser.ts
mhegazy
approved these changes
Mar 6, 2018
Contributor
|
@Andy-MS can you please review and merge |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forbids
let/conststatements to be initialized toundefined, since that's the initial value by default anyway.The auto-fixer also happened to remove two
unnecessaryas numbercasts insrc/harness/parallel/worker.ts.For historical data: to run with
--fix, I modified the line inJakefile.jsthat declared thecmdfor running TSLint.