Skip to content

Handle variable declaration without initializer in Convert to ES6 Module#21835

Merged
amcasey merged 1 commit into
microsoft:masterfrom
amcasey:GH21786
Feb 10, 2018
Merged

Handle variable declaration without initializer in Convert to ES6 Module#21835
amcasey merged 1 commit into
microsoft:masterfrom
amcasey:GH21786

Conversation

@amcasey
Copy link
Copy Markdown
Member

@amcasey amcasey commented Feb 9, 2018

Fixes #21786

@Andy-MS I just guessed, so feel free to suggest a better solution.

@amcasey amcasey requested a review from a user February 9, 2018 19:16
@ghost
Copy link
Copy Markdown

ghost commented Feb 9, 2018

Did you mean fixes #21810?

@ghost
Copy link
Copy Markdown

ghost commented Feb 9, 2018

Never mind, I see that's a separate issue. Though in the same part of the code.

@amcasey
Copy link
Copy Markdown
Member Author

amcasey commented Feb 9, 2018

Looks like it could be a dup though?

@ghost
Copy link
Copy Markdown

ghost commented Feb 9, 2018

Have a separate fix for that at #21843. Will rebase that once this is in. Or you could integrate it into this.

@amcasey
Copy link
Copy Markdown
Member Author

amcasey commented Feb 10, 2018

@mhegazy Shall I port this to 2.7? The hit-count is quite high.

@amcasey amcasey merged commit 22c4862 into microsoft:master Feb 10, 2018
@amcasey amcasey deleted the GH21786 branch February 10, 2018 02:21
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant