findAllReferences: Make definition info independent of search location#21748
Merged
1 commit merged intoMar 1, 2018
Merged
Conversation
mhegazy
approved these changes
Mar 1, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21301
Previously the definition info depended on the search location -- which doesn't make sense as the search location is probably not the definition. As of this PR we will mostly only use the definition symbol when getting definition info; the only exception being that we still use the original search location to get the SemanticMeaning, and we may use the search location as a backup if
symbol.declarationsis empty.