Fix issue where source files could get corrupted.#2167
Merged
Conversation
This could happen when you had multiple language services, and they were sharing some files. If a file got edited in one LS, it could get corrupted in the other. Now, the DocumentRegistry serves as the canonical source of 'good' source files. Language services always go to it to get the correct source file instead of trying to manually update their own source files when they are notified about changes from the host.
…orresponds to the version requested.
Contributor
|
unit test? 👍 |
Contributor
Author
|
@mhegazy adding tests. |
CyrusNajmabadi
added a commit
that referenced
this pull request
Feb 28, 2015
Fix issue where source files could get corrupted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could happen when you had multiple language services, and they were sharing some files.
If a file got edited in one LS, it could get corrupted in the other. Now, the DocumentRegistry
serves as the canonical source of 'good' source files. Language services always go to it to get
the correct source file instead of trying to manually update their own source files when they
are notified about changes from the host.