Fix harness getDirectores implementation to not include directory as prefix#21633
Merged
1 commit merged intoFeb 5, 2018
Merged
Fix harness getDirectores implementation to not include directory as prefix#216331 commit merged into
1 commit merged into
Conversation
Contributor
|
I am completely replacing the implementation of |
Author
|
I went with standardizing returning |
rbuckton
approved these changes
Feb 5, 2018
Contributor
rbuckton
left a comment
There was a problem hiding this comment.
I'll update my PR after this is in.
ghost
pushed a commit
that referenced
this pull request
Feb 6, 2018
ghost
pushed a commit
that referenced
this pull request
Feb 6, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21100 (comment)
We already had fourslash tests for getting directories in path completions. But, the harness implementation of
getDirectoriesdiffered from the original one, as it returned directories with the prefix present.Now directory completions with paths should for real in addition to in fourslash tests. (See the linked comment for repro instructions.)