Skip to content

Produce better wrapping for object literal emit with computed property names.#2163

Merged
CyrusNajmabadi merged 1 commit into
masterfrom
computedPropertyFormatting
Feb 27, 2015
Merged

Produce better wrapping for object literal emit with computed property names.#2163
CyrusNajmabadi merged 1 commit into
masterfrom
computedPropertyFormatting

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/compiler/emitter.ts
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be optional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's optional then it, as a structural type, has no meaning.

CyrusNajmabadi added a commit that referenced this pull request Feb 27, 2015
Produce better wrapping for object literal emit with computed property names.
@CyrusNajmabadi CyrusNajmabadi merged commit 7b22880 into master Feb 27, 2015
@CyrusNajmabadi CyrusNajmabadi deleted the computedPropertyFormatting branch February 27, 2015 01:59
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants