Fix crash by leveraging existing function for finding spread validity#21564
Merged
Conversation
sandersn
approved these changes
Feb 2, 2018
Contributor
|
Please port this to release-2.7 as well. |
Member
Author
|
@mhegazy way ahead of you ;) |
weswigham
added a commit
that referenced
this pull request
Feb 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21554
An intersection type with no alias has no symbol, which triggered the above bug. Now, this PR just leverages an existing function for checking the validity of a type in a spread, rather than attempting to infer from the type's symbol if it could be spread. This is potentially more work than is required (since module exports are all top level types, we know that many generic types can't exist, so don't need to bother checking), but is better because of the consolidation of functionality.