Skip to content

Fix over-aggressive transformation of super properties#21559

Merged
rbuckton merged 1 commit into
masterfrom
fix21543
Feb 1, 2018
Merged

Fix over-aggressive transformation of super properties#21559
rbuckton merged 1 commit into
masterfrom
fix21543

Conversation

@rbuckton
Copy link
Copy Markdown
Contributor

@rbuckton rbuckton commented Feb 1, 2018

Fixes an over-aggressive transformation for calls containing super when targeting ES5 or lower:

// ts
super.foo.bind(this);

// was
(_a = _super.prototype.foo).bind.call(_a, this);
var _a;

// now
_super.prototype.foo.bind(this);

Fixes #21543

@rbuckton rbuckton requested a review from weswigham February 1, 2018 23:23
@rbuckton rbuckton merged commit 06c5d39 into master Feb 1, 2018
@rbuckton rbuckton deleted the fix21543 branch February 1, 2018 23:45
@rbuckton
Copy link
Copy Markdown
Contributor Author

rbuckton commented Feb 1, 2018

@mhegazy do you want this in release-2.7?

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Feb 2, 2018

yes please.

@rbuckton
Copy link
Copy Markdown
Contributor Author

rbuckton commented Feb 2, 2018

done.

@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbuckton @mhegazy @weswigham