Skip to content

Create import helpers for named imports if they contain default imports#21550

Merged
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:esm-interop-named-default-helper
Feb 1, 2018
Merged

Create import helpers for named imports if they contain default imports#21550
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:esm-interop-named-default-helper

Conversation

@weswigham
Copy link
Copy Markdown
Member

Fixes #21541

We only add the helpers if we see they are required because the import references a default import.

@weswigham weswigham requested review from mhegazy and rbuckton February 1, 2018 21:19
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Feb 1, 2018

Please port to release-2.7 as well

@weswigham weswigham merged commit aa5272d into microsoft:master Feb 1, 2018
@weswigham weswigham deleted the esm-interop-named-default-helper branch February 1, 2018 23:46
weswigham added a commit to weswigham/TypeScript that referenced this pull request Feb 1, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants