Enable CFA on this keyword unconditionally#21490
Merged
Merged
Conversation
sandersn
approved these changes
Feb 2, 2018
| const classSymbol = checkExpression(className).symbol; | ||
| if (classSymbol && classSymbol.members && (classSymbol.flags & SymbolFlags.Function)) { | ||
| return getInferredClassType(classSymbol); | ||
| return getFlowTypeOfReference(node, getInferredClassType(classSymbol)); |
Member
There was a problem hiding this comment.
Can you find out if there’s a performance hit for this PR? I would expect this line especially to be costly, since there are probably a lot of this.property references in an OO codebase.
Member
There was a problem hiding this comment.
Never mind, I looked the file locally, outside github’s 3 lines of context, and see that this is for JS.
| @@ -0,0 +1,39 @@ | |||
| === tests/cases/compiler/controlFlowAnalysisOnBareThisKeyword.ts === | |||
| declare function isBig(x: any): x is { big: true }; | |||
Member
There was a problem hiding this comment.
Shouldn’t there be way more type differences than this, since we are now narrowing this in classes? Maybe I’m missing something about the actual change.
Member
There was a problem hiding this comment.
[Later] Yes, I did. But github doesn’t display the “Are you sure you want to delete your comment?” message on the iPad, so I can’t delete it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21248
We already generated these types if, for example, you say
this.prop- we just didn't reflect the narrowed types on the types of the barethisreference if thethiswasn't supplied by a class declaration.