Use the full local file path as the id for a submodule#21471
Merged
weswigham merged 2 commits intoJan 30, 2018
Conversation
mhegazy
reviewed
Jan 30, 2018
| } | ||
| const packageDirectory = path.slice(0, indexAfterPackageName); | ||
| const subModuleName = removeExtensionAndIndex(path.slice(indexAfterPackageName + 1)); | ||
| const subModuleName = addExtensionAndIndex(path.slice(indexAfterPackageName + 1)); |
Contributor
There was a problem hiding this comment.
do we need this here even?
mhegazy
reviewed
Jan 30, 2018
| } | ||
| else { | ||
| const jsPath = tryReadPackageJsonFields(/*readTypes*/ false, packageJsonContent, nodeModuleDirectory, state); | ||
| if (typeof jsPath === "string") { |
mhegazy
approved these changes
Jan 30, 2018
Contributor
mhegazy
left a comment
There was a problem hiding this comment.
We will need to port this to release-2.7 as well.
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Jan 30, 2018
* Use the full file path as the id for a submodule * Informal code review feedback
mhegazy
pushed a commit
that referenced
this pull request
Jan 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21446
The issue was essentialy that the package id name generation logic assumed that
foo/barwas always the same asfoo/bar/index.d.ts, which isn't true if you also have afoo/bar.d.ts(which takes priority over the other when referenced shorthand).