Support new import / export syntax in preProcessFile#2140
Merged
Conversation
Contributor
There was a problem hiding this comment.
why not just while (token !== SyntaxKind.CloseBraceToken)? when we might expect another OpenBraceToken?
Contributor
Author
There was a problem hiding this comment.
i was thinking of an unterminated brace, and did not want to eat up the whole file.. thought it does not make much difference..
Contributor
There was a problem hiding this comment.
If you gonna leave the !== SyntaxKind.OpenBraceToken could you make comment of why you do that? I have similar question as @vladima
Contributor
|
👍 |
mhegazy
added a commit
that referenced
this pull request
Feb 28, 2015
Support new import / export syntax in preProcessFile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.