Remove optimization of eliding the preamble code for functions without statements.#2138
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
i guess this isn't really necessary. If 'startIndex' were not zero, then 'preambleEmitted' would be 'true' and we wouldn't get in this branch.
Contributor
There was a problem hiding this comment.
Don't you need to start at 0 regardless? I presume the prologues are not actually in the body.statements array.
Contributor
There was a problem hiding this comment.
So now every function block will be on multiple lines?
Contributor
Author
There was a problem hiding this comment.
No. Functions with preambles will alwys be on multiple lines. If thre is no preamble, then the function will stay on a single line if it was written on a single line. Otherwise, it will become multiple lines.
Contributor
|
👍 |
Conflicts: src/compiler/emitter.ts
CyrusNajmabadi
added a commit
that referenced
this pull request
Feb 25, 2015
Remove optimization of eliding the preamble code for functions without statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.