Print deferred mapped symbols 1 level deep#21311
Merged
Merged
Conversation
Previously, deferred mapped symbols would not print their type at all; it would always print as `any`. This differed from the older behaviour that printed it forever if necessary. As a compromise, we now print deferred mapped symbosl 1 level deep before giving up and printing `any`. This should cover the most common uses of mapped types.
weswigham
approved these changes
Feb 6, 2018
Member
weswigham
left a comment
There was a problem hiding this comment.
Just the one comment, but definitely seems like an improvement. 👍 (Though I still wish these types were printed with less heuristics and more totally 🙁 )
| const globals = createSymbolTable(); | ||
| const reverseMappedCache = createMap<Type | undefined>(); | ||
| let ambientModulesCache: Symbol[] | undefined; | ||
| let alreadyCreatingReverseMappedType = false; |
Member
There was a problem hiding this comment.
This should be a state flag in context, instead of a local flag so it can be tracked across calls, I think.
mhegazy
approved these changes
Feb 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, deferred mapped symbols would not print their type at all; they would always print as
any. This differed from the older behaviour that printed it forever if necessary. As a compromise, we now print deferred mapped symbosl 1 level deep before giving up and printingany. This should cover the most common uses of mapped types.The baseline updates are the easiest-to-understand examples of this change.