Simplify TextSpan creation#21306
Merged
3 commits merged intoFeb 8, 2018
Merged
Conversation
armanio123
reviewed
Jan 19, 2018
|
|
||
| private computeSpan(change: Change, _sourceFile: SourceFile): TextSpan { | ||
| return createTextSpanFromBounds(change.range.pos, change.range.end); | ||
| return createTextSpanFromRange(change.range); |
Contributor
There was a problem hiding this comment.
Is this name the intended one? On other files the method is creatTextSpanFromStartEnd.
Author
There was a problem hiding this comment.
This and createTextSpanFromStartEnd are basically the same functions, only some data structures use { start, end } and others use { pos, end } for some reason.
Contributor
There was a problem hiding this comment.
If both methods (FromStartEnd and FromRange) achieves the same goal, is it preferable to instead refactor to use the FromRange and not introduce a new method?
Author
There was a problem hiding this comment.
👍 Changed this so that they call it pos consistently
mhegazy
approved these changes
Feb 8, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a helper function and uses existing helpers more.