Fix formatting between for and await - #21254
Merged
Mohamed Hegazy (mhegazy) merged 2 commits intoJan 21, 2018
Merged
Conversation
|
|
|
|
||
| // Remove extra space between for and await | ||
| rule("SpaceAfterFor", SyntaxKind.ForKeyword, anyToken, [ isNonJsxSameLineTokenContext ], RuleAction.Space), | ||
| rule("NoSpaceBeforeAwait", anyToken, SyntaxKind.AwaitKeyword, [ isNonJsxSameLineTokenContext ], RuleAction.Delete), |
Contributor
There was a problem hiding this comment.
i do not think this rule is needed.
Mohamed Hegazy (mhegazy)
suggested changes
Jan 18, 2018
| rule("SpaceAfterSemicolon", SyntaxKind.SemicolonToken, anyToken, [isNonJsxSameLineTokenContext], RuleAction.Space), | ||
|
|
||
| // Remove extra space between for and await | ||
| rule("SpaceAfterFor", SyntaxKind.ForKeyword, anyToken, [ isNonJsxSameLineTokenContext ], RuleAction.Space), |
Contributor
There was a problem hiding this comment.
call this SpaceBetweenForAndAwaitKeyword. also make it between SyntaxKind.ForKeyword and SyntaxKind.AwaitKeyword, the others are already covered by other rules.
| rule("SpaceAfterSemicolon", SyntaxKind.SemicolonToken, anyToken, [isNonJsxSameLineTokenContext], RuleAction.Space), | ||
|
|
||
| // Remove extra space between for and await | ||
| rule("SpaceAfterFor", SyntaxKind.ForKeyword, anyToken, [ isNonJsxSameLineTokenContext ], RuleAction.Space), |
Contributor
There was a problem hiding this comment.
nit: formatting, please remove space before and after [ and ]
Contributor
Author
|
Mohamed Hegazy (@mhegazy) Updated the pull request with the changes mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21084