Skip to content

Update project structure on idle after change#2125

Merged
steveluc merged 2 commits into
masterfrom
updateProjectStructure
Feb 26, 2015
Merged

Update project structure on idle after change#2125
steveluc merged 2 commits into
masterfrom
updateProjectStructure

Conversation

@steveluc
Copy link
Copy Markdown
Contributor

Update project structure after change. After each change a timer is started. If timer finishes before another change takes place, project structure will be updated to reflect any changes in reference comments or import statements.

timer is started.  If timer finishes before another change takes place,
project structure will be updated to reflect any changes in reference
comments or import statements.
Comment thread src/server/session.ts
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't include parens around the parameter list for single-argument arrow functions. That occurs here, line 201, and 188.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment on why calling updateGraph or what it does will be helpful in this context

@DanielRosenwasser
Copy link
Copy Markdown
Member

@mihailik the goal is for the compiler to run in an ES3 environment; I believe that here we assume a node-compatible system, which means ES5 is acceptable. We're free to choose with code in our tests & scripts directories.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Feb 25, 2015

👍

steveluc added a commit that referenced this pull request Feb 26, 2015
Update project structure on idle after change
@steveluc steveluc merged commit 42bc64b into master Feb 26, 2015
@steveluc steveluc deleted the updateProjectStructure branch February 26, 2015 05:59
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants