In formatter, get lineAction directly from applyRuleEdits#21245
Merged
1 commit merged intoJan 18, 2018
Merged
Conversation
mhegazy
approved these changes
Jan 17, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20508
processPairwas trying to calculatelineActionbased only onrule.action.But only
applyRuleEditsknows whether a line was actually added/deleted; in this case there was aRuleAction.Spacerule that happened to do nothing, butprocessPairwas assuming that it had removed a line, which meant that we didn't try to correct the indentation for the line withx,.