AFAICT this PR only handles identifiers. This is an issue for property access as well.

({foo, bar} = foo.bar);
// or
({foo: foo.bar, bar} = foo.bar);

I don't know if this is really necessary or just theoretically possible but never actually used in real world code.

@ajafff we already handle ({ foo, bar } = foo.bar), but you are correct that this doesn't resolve ({foo: foo.bar, bar} = foo.bar), however it looks like babel doesn't handle this case either. Also, neither TS nor Babel supports ({ foo: foo.bar, bar } = foo) correctly either. There's also no way to know whether ({ foo: foo.bar, bar } = baz) will have the wrong semantics if baz points to the same object as foo.

For now I'd consider this "good enough". The only other change we could make would be to create temporaries for every result before we begin assignments, however this can generate a lot of temporaries.