Skip to content

Fix empty array inference#21157

Merged
ahejlsberg merged 4 commits into
masterfrom
fixEmptyArrayInference
Jan 16, 2018
Merged

Fix empty array inference#21157
ahejlsberg merged 4 commits into
masterfrom
fixEmptyArrayInference

Conversation

@ahejlsberg
Copy link
Copy Markdown
Member

During inference we now retain inferences from both co- and contra-variant positions, and if the covariant candidates yield never we instead infer from the contravariant candidates. This ensures that we only infer never if there truly is nothing else to infer from.

Fixes #21112.

@ghost
Copy link
Copy Markdown

ghost commented Jan 12, 2018

May fix #19873?

@ahejlsberg
Copy link
Copy Markdown
Member Author

@Andy-MS No, that's an unrelated issue.

@falsandtru
Copy link
Copy Markdown
Contributor

ping @sandersn @mhegazy

@ahejlsberg ahejlsberg merged commit 64b3086 into master Jan 16, 2018
@ahejlsberg ahejlsberg deleted the fixEmptyArrayInference branch January 16, 2018 20:42
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants