Skip to content

quick fix of indexed access#20956

Merged
mhegazy merged 1 commit into
microsoft:masterfrom
Kingwl:quick-fix-indexed-access
Jan 4, 2018
Merged

quick fix of indexed access#20956
mhegazy merged 1 commit into
microsoft:masterfrom
Kingwl:quick-fix-indexed-access

Conversation

@Kingwl
Copy link
Copy Markdown
Contributor

@Kingwl Kingwl commented Jan 2, 2018

Fixes #20833

@Kingwl Kingwl force-pushed the quick-fix-indexed-access branch from 0fe6d60 to 5d146e6 Compare January 2, 2018 06:16
@RyanCavanaugh
Copy link
Copy Markdown
Member

What's the explanation for why the assert was wrong?

@Kingwl Kingwl force-pushed the quick-fix-indexed-access branch from 5d146e6 to fc7d456 Compare January 3, 2018 02:36
@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Jan 3, 2018

ping @RyanCavanaugh
updated
because includeJsDocComment is false then token is redirected to function keyword
happy new year 😄

@mhegazy mhegazy merged commit 2ea5f58 into microsoft:master Jan 4, 2018
@Kingwl Kingwl deleted the quick-fix-indexed-access branch January 5, 2018 04:26
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants