Check whether we have a class before testing whether we have a super-class#20928
Merged
DanielRosenwasser merged 3 commits intoDec 29, 2017
Merged
Conversation
3d2677d to
00cc709
Compare
00cc709 to
b899c49
Compare
RyanCavanaugh
approved these changes
Dec 29, 2017
Member
Author
|
Maybe obvious, but the reason we do this check can be found at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20925
I'd try putting the tests in a single file, but somehow TypeScript wasn't reporting the errors in the constituent files.I just made a single file with multiple tests.