fix #20018, allow skip constraint when merging interfaces#20883
Merged
rbuckton merged 1 commit intoJan 5, 2018
Conversation
rbuckton
approved these changes
Jan 5, 2018
Contributor
|
Looks good, thanks! |
This was referenced May 4, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20018
This fix is order sensitive: only interface declared later can skip constraint. Interface declared at first must specify constraint.
Current code base assumes all interfaces have same constraints, so interface types and their typenodes are immutable. Supporting order independent constraint skipping would involve much mutation so I didn't attempt it at first try.