Skip to content

Fix quick info for require template string#20851

Merged
mhegazy merged 2 commits into
microsoft:masterfrom
mjbvz:quick-info-template-no-sub
Jan 4, 2018
Merged

Fix quick info for require template string#20851
mhegazy merged 2 commits into
microsoft:masterfrom
mjbvz:quick-info-template-no-sub

Conversation

@mjbvz
Copy link
Copy Markdown
Contributor

@mjbvz mjbvz commented Dec 21, 2017

Fixes #20850

Enables quick info for require calls that use template strings without any substitutions

@DanielRosenwasser
Copy link
Copy Markdown
Member

Sweet! Can you add a test to make sure that a require call with a template path also returns something with appropriate completion items and the like?

Nit: I think this might augment the syntax for import foo = require("blah"). We should discuss whether that's okay.

@mhegazy mhegazy merged commit 3f577b8 into microsoft:master Jan 4, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants