Stop assuming code fix test changes are in the originating file#20713
Merged
Conversation
Triggering a fix in one file can result in changes in another file. Instead of passing around the originating file, retrieve an appropriate `ScriptInfo` for each `FileTextChanges`. Fixes microsoft#19165
ghost
approved these changes
Dec 15, 2017
RyanCavanaugh
approved these changes
Dec 15, 2017
Member
|
If you want to have a test for this, a fourslash file in |
Member
Author
|
We established offline that the fourslash server tests are unable to provide coverage of this scenario. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggering a fix in one file can result in changes in another file.
Instead of passing around the originating file, retrieve an appropriate
ScriptInfofor eachFileTextChanges.Fixes #19165