Handle arrays with properties in assert.deepEqual#20674
Merged
Conversation
Author
|
Now that we're testing for this, had to change a few tests to use |
weswigham
approved these changes
Dec 13, 2017
Member
weswigham
left a comment
There was a problem hiding this comment.
It feels a tad unfortunate to do it this way (the deep equal library exposes an options object where you can pass in a comparator, so it could be handled that way), but I guess it's better for this behavior to be the default.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting a fix from #20429