If declaration emit input is a module, output should be a module#20626
Merged
weswigham merged 1 commit intoJan 8, 2018
Merged
Conversation
mhegazy
approved these changes
Jan 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20496
We tried to ensure this if the module contained module augmentations, but the code for that missed a lot of module indicator nodes (and would emit
export {}too eagerly), so in addition to removing the restriction of only doing it for files with module augmentations, I had to tighten that up a bit. There's still a bunch of tests with changes to addexport {}, but they should have them since the input file was a module.