Reimplement #20320 differently to handle multiple check orders better#20588
Merged
weswigham merged 2 commits intoDec 11, 2017
Conversation
sandersn
approved these changes
Dec 11, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
It doesn't look *that clunky, and I like the elimination of the scary "Reset the referenced-ness" code.
| const assignmentKind = getAssignmentTargetKind(node); | ||
| const prop = getPropertyOfType(apparentType, right.escapedText); | ||
| if (!prop) { | ||
| if (isIdentifier(left) && parentSymbol) { |
Member
There was a problem hiding this comment.
Would it read better to lift this check out if the prop/!prop if? Put it afterwards, as:
if (isIdentifier(left) && parentSymbol && (!prop || !isConstEnumOrConstEnumOnlyModule(prop))) ...(and it would probably read better to invert the !prop/prop if, but that's out of scope here)
Member
Author
There was a problem hiding this comment.
Probably, considering it's repeated before all exit points of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the remaining RWC breaks @sandersn mentioned (verified - the only changes in the affected tests with this change are error message changes from the changes to contextual literal types).
Now, instead of collecting the referenced status prior to checking the LHS, then resetting it (which could fail if the LHS didn't already have a resolved symbol, which was the issue), now this simply disables reference marking for identifiers which are the LHS of a property access expression, and instead does the reference marking for such nodes' symbols inside
checkPropertyAccxessExpressionOrQualifiedName. This is less general (it can't handle eliding when there are arbitrary non-identifier LHS productions), but covers the common (reported) usecase.