Merged
Conversation
| return token = SyntaxKind.CommaToken; | ||
| case CharacterCodes.dot: | ||
| pos++; | ||
| if (text.substr(tokenPos, pos + 2) === "...") { |
Member
There was a problem hiding this comment.
How was this not a bug before?
Author
There was a problem hiding this comment.
I don't think we actually do anything with this kind of token in this context. We could just take out this code.
mhegazy
approved these changes
Jan 8, 2018
Contributor
|
@sandersn can you take a look. |
Member
|
What does this fix? After reading half the changes I don't see uses of substr or substring yet. |
sandersn
approved these changes
Jan 8, 2018
Author
|
@sandersn It's confusing if you just look at the end result -- original commit just changed |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
substrtakes start and length,substringtakes start and end.