Skip to content

Support completions that require changing from dot to bracket access #20547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
10 commits merged into from
Jan 9, 2018
Merged

Support completions that require changing from dot to bracket access #20547

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
53bc018
Support completions that require changing from dot to bracket access
Dec 7, 2017
6555283
Use insertText and replacementSpan
Dec 18, 2017
84f9203
Merge branch 'master' into completionsBracket
Dec 18, 2017
fd9ea5b
Rename includeBracketCompletions to includeInsertTextCompletions
Dec 19, 2017
4f5f540
Merge branch 'master' into completionsBracket
Jan 4, 2018
5091bfc
Merge branch 'master' into completionsBracket
Jan 4, 2018
8a504d5
Don't add completions that start with space
Jan 4, 2018
b1756bb
Merge branch 'master' into completionsBracket
Jan 4, 2018
f197019
Merge branch 'master' into completionsBracket
Jan 5, 2018
2abd602
Merge branch 'master' into completionsBracket
Jan 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into completionsBracket
  • Loading branch information
Andy Hanson committed Jan 4, 2018
commit b1756bb05a8a00dee7f17d67e278bfda557f79cf
10 changes: 9 additions & 1 deletion tests/cases/fourslash/completionsPaths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@
// @Filename: /src/folder/b.ts
////import {} from "x/[|/*2*/|]";

const [r0, r1] = test.ranges();
// @Filename: /src/folder/c.ts
////const foo = require("x/[|/*3*/|]");

// @Filename: /src/folder/4.ts
////const foo = require(`x/[|/*4*/|]`);

const [r0, r1, r2, r3] = test.ranges();
verify.completionsAt("1", [{ name: "y", replacementSpan: r0 }, { name: "x", replacementSpan: r0 }]);
verify.completionsAt("2", [{ name: "bar", replacementSpan: r1 }, { name: "foo", replacementSpan: r1 }]);
verify.completionsAt("3", [{ name: "bar", replacementSpan: r2 }, { name: "foo", replacementSpan: r2 }]);
verify.completionsAt("4", [{ name: "bar", replacementSpan: r3 }, { name: "foo", replacementSpan: r3 }]);
You are viewing a condensed version of this merge commit. You can view the full changes here.