imporve conditional operator if missing colon#20498
Merged
Merged
Conversation
2acc98d to
d2290b1
Compare
RyanCavanaugh
requested changes
Dec 6, 2017
| parseErrorAtCurrentToken(diagnosticMessage, arg0); | ||
| } | ||
|
|
||
| function createMissingNodePlaceholder<T extends Node>(kind: T["kind"]) { |
Member
There was a problem hiding this comment.
We don't need a new kind of missing node to handle this one case. Please work with the existing infrastructure for missing nodes
3013274 to
dd5944c
Compare
dd5944c to
0ed630a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6127
ps:
createMissingNodewithIdentifiertype ifcolonTokenis missing becauseparseAssignmentExpressionOrHigherwith empty return it. have there got any better solution？jsxAndTypeAssertionis changed but i have no idea about that