Skip to content

Immediately respond to applyCodeActionCommand requests#20448

Merged
3 commits merged into
masterfrom
applyCodeActionCommand_immediate
Dec 5, 2017
Merged

Immediately respond to applyCodeActionCommand requests#20448
3 commits merged into
masterfrom
applyCodeActionCommand_immediate

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 4, 2017

Fixes #20085
Does not fix #20447

@amcasey Could you verify that this fixes the problem in Visual Studio?

@amcasey
Copy link
Copy Markdown
Member

amcasey commented Dec 4, 2017

Manually confirmed that it was blocking and is non-blocking.

Copy link
Copy Markdown
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it turns out that there's no way to report the exit status, will we eliminate the Promise wrapper altogether?

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2017

There is a public services method (applyCodeActionCommand) already returning a Promise so it would be hard to remove entirely.

@ghost ghost force-pushed the applyCodeActionCommand_immediate branch from 72b12d9 to 1b12b44 Compare December 5, 2017 20:50
@ghost ghost merged commit 3a3bb8e into master Dec 5, 2017
@ghost ghost deleted the applyCodeActionCommand_immediate branch December 5, 2017 21:19
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report errors from session applyCodeActionCommands should not wait for typings installation to complete

1 participant