Fewer intermediate object literal and array literal types#20380
Merged
Conversation
mhegazy
approved these changes
Dec 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we create fewer intermediate object literal and array literal types. We now preserve literal types for object literal properties and array literal elements only when the corresponding contextual type contains literals of the same primitive type. Previously, we would preserve literal types for properties in object literals and elements in array literals when the corresponding contextual type contained any literal type. This for example meant that we would preserve string literal types for object literal properties and array literal elements if the contextual type contained one (or both) of the literals
trueorfalse--in other words, whenever the contextual type containedboolean. Generally this was harmless and only affected types shown in error messages, but on rare occasions (e.g. #20279) it could cause huge numbers of intermediate object literal or array literal types to be created which would subsequently slow down subtype reduction and type relationship checking.The only changes in to the real world code tests are in error messages.
Fixes #20279.