compileOnSaveAffectedFileList shouldn't return any files for noEmit projects#20369
Merged
Conversation
amcasey
reviewed
Nov 30, 2017
| const projectsToSearch = args.projectFileName ? [this.projectService.findProject(args.projectFileName)] : info.containingProjects; | ||
| for (const project of projectsToSearch) { | ||
| if (project.compileOnSaveEnabled && project.languageServiceEnabled) { | ||
| if (project.compileOnSaveEnabled && project.languageServiceEnabled && !project.getCompilerOptions().noEmit) { |
Member
There was a problem hiding this comment.
Can noEmit be undefined? Would it be safer to check for true explicitly?
Member
Author
There was a problem hiding this comment.
This should be safe because the default value of noEmit is false.
Member
|
I don't suppose there's a way to write a test for this change? |
amcasey
approved these changes
Nov 30, 2017
Member
Author
|
@amcasey I think there might already exist some tests for this. I should update them. |
Member
|
@minestarks They appear not to have failed. 😛 |
2019c6f to
1fbe684
Compare
Member
Author
|
I added a test and changed the code to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compileOnSaveAffectedFileList can be expensive, and there is no point in gathering up a list of files to be emitted only to throw it away later.