installTypesForPackage refactor: Trigger even if resolved to a ".js" file#20353
Merged
2 commits merged intoNov 30, 2017
Merged
installTypesForPackage refactor: Trigger even if resolved to a ".js" file#203532 commits merged into
2 commits merged into
Conversation
amcasey
approved these changes
Nov 30, 2017
| // Still offer to install types if it resolved to e.g. a ".js" file. | ||
| // `tryGetCodeActionForInstallPackageTypes` will verify that we're looking for a valid package name, | ||
| // so the fix won't trigger for imports of ".js" files that couldn't be better replaced by typings. | ||
| if (resolvedTo && resolvedTo.extension === Extension.Dts) { |
Member
There was a problem hiding this comment.
Can it resolve to a ts file and, if so, do we want to suppress the code action in that case?
Author
There was a problem hiding this comment.
It shouldn't matter because tryGetCodeActionForInstallPackageTypes will verify that we're looking for a valid package name, which don't contain .ts files when installed, but I've changed this to use extensionIsTypeScript anyway since it's just as easy.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20087